Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_14_0_X] Update L1T menu tag to L1Menu_Collisions2024_v1_2_0_xml #44861

Merged
merged 1 commit into from
May 1, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Apr 28, 2024

PR description:

Update L1T menu with L1Menu_Collisions2024_v1_2_0_xml, as from cmsTalk https://cms-talk.web.cern.ch/t/gt-mc-data-relval-update-of-the-2024-l1t-menu-tag-l1menu-collisions2024-v1-2-0/39826

The new L1T menu tag is L1Menu_Collisions2024_v1_2_0_xml which replaces the previous L1Menu_Collisions2024_v1_1_0_xml. The difference wrt the previous tag is just the addition of a few L1 HQ bits for lumi-decay.

All the differences w.r.t. the previous L1T menu are summarized here , and can be visible also via the Payload Inspector:

PLI_L1TriggerMenu2024

GT differences with the previous ones only relate to the updated L1T menu tag:

PR validation:

See master branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #44860

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@consuegs, @saumyaphor4252, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@yuanchao, @fabiocos, @Martin-Grunewald, @tocheng, @rsreds, @mmusich, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fbe40/39129/summary.html
COMMIT: 31ceaff
CMSSW: CMSSW_14_0_X_2024-04-28-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44861/39129/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 39 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3326485
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3326459
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

+1

  • Master version of this PR is merged, and IB tests show no issues

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2a68a8 into cms-sw:CMSSW_14_0_X May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants